MINOR Removed copying storage libraries specifically as the task already copies them. #10647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ijuma
reviewed
May 7, 2021
| from(project(':storage').jar) { into("libs/") } | ||
| from(project(':storage').configurations.runtimeClasspath) { into("libs/") } | ||
| from(project(':storage:api').jar) { into("libs/") } | ||
| from(project(':storage:api').configurations.runtimeClasspath) { into("libs/") } |
There was a problem hiding this comment.
Can you clarify why this is not needed?
There was a problem hiding this comment.
I observed that these libraries are copied as mentioned here.
from(configurations.runtimeClasspath) { into("libs/") }
There was a problem hiding this comment.
Makes sense, we only need to add modules that are not a core dependency already.
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
May 16, 2021
…e-allocations-lz4 * apache-github/trunk: (155 commits) KAFKA-12728: Upgrade gradle to 7.0.2 and shadow to 7.0.0 (apache#10606) KAFKA-12778: Fix QuorumController request timeouts and electLeaders (apache#10688) KAFKA-12754: Improve endOffsets for TaskMetadata (apache#10634) Rework on KAFKA-3968: fsync the parent directory of a segment file when the file is created (apache#10680) MINOR: set replication.factor to 1 to make StreamsBrokerCompatibilityService work with old broker (apache#10673) MINOR: prevent cleanup() from being called while Streams is still shutting down (apache#10666) KAFKA-8326: Introduce List Serde (apache#6592) KAFKA-12697: Add Global Topic and Partition count metrics to the Quorum Controller (apache#10679) KAFKA-12648: MINOR - Add TopologyMetadata.Subtopology class for subtopology metadata (apache#10676) MINOR: Update jacoco to 0.8.7 for JDK 16 support (apache#10654) MINOR: exclude all `src/generated` and `src/generated-test` (apache#10671) KAFKA-12772: Move all transaction state transition rules into their states (apache#10667) KAFKA-12758 Added `server-common` module to have server side common classes. (apache#10638) MINOR Removed copying storage libraries specifically as they are already copied. (apache#10647) KAFKA-5876: KIP-216 Part 4, Apply InvalidStateStorePartitionException for Interactive Queries (apache#10657) KAFKA-12747: Fix flakiness in shouldReturnUUIDsWithStringPrefix (apache#10643) MINOR: remove unnecessary placeholder from WorkerSourceTask#recordSent (apache#10659) MINOR: Remove unused `scalatest` definition from `dependencies.gradle` (apache#10655) MINOR: checkstyle version upgrade: 8.20 -> 8.36.2 (apache#10656) KAFKA-12464: minor code cleanup and additional logging in constrained sticky assignment (apache#10645) ...
satishd
added a commit
to satishd/kafka
that referenced
this pull request
May 31, 2021
…ady copied. (apache#10647) Reviewers: Ismael Juma <[email protected]>, Jun Rao <[email protected]>
kamalcph
pushed a commit
to satishd/kafka
that referenced
this pull request
Jun 21, 2021
…ady copied. (apache#10647) Reviewers: Ismael Juma <[email protected]>, Jun Rao <[email protected]>
satishd
added a commit
to satishd/kafka
that referenced
this pull request
Aug 12, 2021
…ady copied. (apache#10647) Summary: apache-reviewers: Ismael Juma <[email protected]>, Jun Rao <[email protected]> (cherry picked from commit 80a468e) Reviewers: #ldap_kafka_admins, kchandraprakash Reviewed By: #ldap_kafka_admins, kchandraprakash JIRA Issues: DKAFC-868 Differential Revision: https://code.uberinternal.com/D6303235
divijvaidya
pushed a commit
to Hangleton/kafka
that referenced
this pull request
Apr 28, 2022
…ady copied. (apache#10647) Summary: apache-reviewers: Ismael Juma <[email protected]>, Jun Rao <[email protected]> (cherry picked from commit 80a468e) Reviewers: #ldap_kafka_admins, kchandraprakash Reviewed By: #ldap_kafka_admins, kchandraprakash JIRA Issues: DKAFC-868 Differential Revision: https://code.uberinternal.com/D6303235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configurations.runtimeClasspathinreleaseTarGz.Committer Checklist (excluded from commit message)